Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add preset_counts to agent_per_output_type telemetry #172838

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[Fleet] Add preset_counts to agent_per_output_type telemetry #172838

merged 3 commits into from
Dec 7, 2023

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Dec 7, 2023 •
edited
Loading

Summary

Closes #172818

Adds a preset_counts property to the agents_per_output_type record in the Fleet Usage telemetry, e.g.

[
  {
    output_type: 'elasticsearch',
    count_as_data: 5,
    count_as_monitoring: 5,
    preset_counts: { balanced: 2, custom: 1, latency: 0, scale: 0, throughput: 1 }
  },
  { output_type: 'logstash', count_as_data: 1, count_as_monitoring: 0 },
  { output_type: 'kafka', count_as_data: 0, count_as_monitoring: 1 },
  {
    output_type: 'remote_elasticsearch',
    count_as_data: 1,
    count_as_monitoring: 1,
    preset_counts: { balanced: 0, custom: 0, latency: 0, scale: 1, throughput: 0 }
  }
]

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 7, 2023
@kpollich kpollich self-assigned this Dec 7, 2023
@kpollich kpollich requested a review from a team as a code owner December 7, 2023 15:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpollich kpollich mentioned this pull request Dec 7, 2023
Closed
10 tasks
nchaulet
nchaulet approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 you should probably have a follow up PR in telemetry to add the mappings

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 12dccd3 into elastic:main Dec 7, 2023
39 checks passed
@kpollich kpollich deleted the fleet/preset-telemetry branch December 7, 2023 17:31
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 7, 2023
This was referenced Dec 18, 2023
Closed
Merged
juliaElastic added a commit that referenced this pull request Dec 18, 2023
@juliaElastic
[8.12][Fleet] Upgrade details telemetry (#173356) (#173502)
8904970 
Backport #173356

I got a merge conflict on backporting to 8.12, because the presets
telemetry was not backportet, is that intentional?
#172838
@juliaElastic
Copy link
Contributor

@kpollich I believe this should be backported to 8.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@kpollich kpollich

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Add telemetry to output presets
7 participants
@kpollich @elasticmachine @apmmachine @kibana-ci @juliaElastic @nchaulet @kibanamachine